Skip to content

Conversation

@andygruening
Copy link
Contributor

@andygruening andygruening commented Oct 10, 2025

SDK compared strings, but our API returns addresses with different case sensitivities. Error:

Expected contract address from indexer response (0xc2132d05d31c914a87c6611c10748aeb04b58e8f) to match contract address we queried (0xc2132D05D31c914a87C6611C10748AEb04B58e8F)

With this PR, its doing the comparison using our Address class, which ignores case sensitivity.

Version Increment

Please ensure you have incremented the package version in the package.json as necessary.

  • I have incremented the package.json according to semantic versioning
  • No version increment is needed; the change does not impact SDK or Sample code/assets

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

@andygruening andygruening requested a review from a team as a code owner October 10, 2025 08:09
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2025

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 882df34
Status: ✅  Deploy successful!
Preview URL: https://6287fddc.sequence-unity.pages.dev
Branch Preview URL: https://fix-invalid-fee-addreses.sequence-unity.pages.dev

View logs

@andygruening andygruening merged commit 9f673af into master Oct 10, 2025
12 of 14 checks passed
@andygruening andygruening deleted the Fix/invalid-fee-addreses branch October 10, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants